RayTrace082 / untamedwilds

GNU General Public License v3.0
14 stars 11 forks source link

Untamed Wilds crashing in multiplayer #251

Open pintaku opened 1 year ago

pintaku commented 1 year ago

https://pastebin.com/gEGFqaZd


works fine in singleplayer! i have searched far and wide to try and fix this, downgrading does not fix, and there are no later versions. any help would be VERY appreciated, thank you!

suiramdev commented 1 year ago

Anybody have found a way to fix this? A friend is having a similar issue :


java.lang.NullPointerException: Cannot invoke "untamedwilds.util.EntityDataHolder.getScale(int)" because the return value of "untamedwilds.entity.ComplexMob.getEntityData(net.minecraft.world.entity.EntityType)" is null

    at untamedwilds.entity.ComplexMob.getModelScale(ComplexMob.java:195) ~[untamedwilds-1.19.2-3.0.2.jar%23294!/:1.19.2] {re:classloading}

    at untamedwilds.entity.mammal.EntityBaleenWhale.getMultiparts(EntityBaleenWhale.java:260) ~[untamedwilds-1.19.2-3.0.2.jar%23294!/:1.19.2] {re:classloading}

    at untamedwilds.entity.mammal.EntityBaleenWhale.<init>(EntityBaleenWhale.java:53) ~[untamedwilds-1.19.2-3.0.2.jar%23294!/:1.19.2] {re:classloading}
Caltinor commented 1 year ago

For context in the issue mentioned above. Project MMO will use EntityType.create to create a default entity instance for getting entity stats and other information necessary to calculate the XP PMMO will award from it.

Proxwian commented 1 year ago

Same issue here, WITHOUT ProjectMMO

Proxwian commented 1 year ago

crash-2023-08-22_23.25.35-client.txt

RayTrace082 commented 1 year ago

Tested on 1.18.2, with ProjectMMO as a way to test default entity instances, and the only problems I can see are small visual issues (tested on both server and client)

Unless anyone can provide a setup with which I can replicate this crash, I will close the issue

Proxwian commented 1 year ago

You can test it on OxFORTPACK modpack version 8.2. Looks like I removing untamedwilds in another update

Proxwian commented 1 year ago

It happens in singleplayer too

RayTrace082 commented 1 year ago

I have been exploring a bit on the OxFORTPACK pack with no issues, do you happen to have a world file where I can replicate the problem to check if my changes have fixed it?

Caltinor commented 1 year ago

Tested on 1.18.2, with ProjectMMO as a way to test default entity instances, and the only problems I can see are small visual issues (tested on both server and client)

Unless anyone can provide a setup with which I can replicate this crash, I will close the issue

To test With pmmo:

  1. Enter any world
  2. press "P" to open the glossary
  3. click "Open Glossary" for the select menu.
  4. Choose "XP sources" for the first option and "entities" for the second.
  5. click "view info".
  6. See crash.
RayTrace082 commented 1 year ago

Okay, I don't get any crash by following these instructions, gonna publish the 1.18 update in a bit and see if that fixes it

The only issue I do see is that mobs' heads look strange

Caltinor commented 1 year ago

So, I also created a sandboxed environment to test this and could not repeat the results. Based on the modpacks i know have been experiencing the issue, my hypothesis at this point is that there is some sort of mixin and/or performance mod causing conflicts. I had a similar rendering error using the same procedures on the Strictly Medieval modpack but it threw the error for another mod.

For PMMO 1.19.2 I have added a client toggle to disable entity rendering in GUIs which seems to have solved this issue symptomatically.

vgrynch commented 1 year ago

1.19.2, client-side logs spammed by the same exceptions. After playing a while, client-side crashed finally.

RayTrace082 commented 1 year ago

Should be fixed in the latest 1.19.2 version, post log if it is not