search

RayTracing / gpu-tracing

Ray tracing on GPU systems
https://raytracing.github.io/gpu-tracing
Creative Commons Attribution 4.0 International
100 stars 6 forks source link

Edit pass on Chapter 01 #8

Closed rupsis closed 3 months ago

rupsis commented 6 months ago

All changes presented here are suggestions.

These suggestions are largely subjective, with the occasional objective suggestion (i.e spelling correction). I'll try to annotate my changes, and provide additional editing notes.

Feel free to either open a dialogue on this PR, and I'll work with you on edits. Or use this as a reference (cherry pick suggestions) and close the PR out.

Note: This is an editing pass, and by no means a comprehensive revision.

armansito commented 3 months ago

Hey @rupsis, sorry for taking a long time on getting back to you. I agree with most of your suggestions, I went ahead and applied them (with some minor tweaks) to the dev branch.

Please go ahead and close this PR. Thank you very much for the edits!

rupsis commented 3 months ago

Hey @rupsis, sorry for taking a long time on getting back to you. I agree with most of your suggestions, I went ahead and applied them (with some minor tweaks) to the dev branch.

Please go ahead and close this PR. Thank you very much for the edits!

Hey @armansito No worries at all :)

I'm happy to provide more edits in the future (provided they're useful) if you're interested.

armansito commented 3 months ago

Hey @rupsis, sorry for taking a long time on getting back to you. I agree with most of your suggestions, I went ahead and applied them (with some minor tweaks) to the dev branch. Please go ahead and close this PR. Thank you very much for the edits!

Hey @armansito No worries at all :)

I'm happy to provide more edits in the future (provided they're useful) if you're interested.

Yes, I'd definitely appreciate your feedback on the rest of the book, especially once it's complete.