RayTracing / raytracing.github.io

Main Web Site (Online Books)
https://raytracing.github.io/
Creative Commons Zero v1.0 Universal
8.16k stars 821 forks source link

[book 3][ch 6.1] Image doesn't match the settings #1197

Open genmeblog opened 10 months ago

genmeblog commented 10 months ago

When I change samples per pixel from 64 to 100 (as it is in listing 17) my image is still much noisier than Image 3. In my reimplementation 1000 gives the matching result.

genmeblog commented 10 months ago

Rendered examples on my side (possibly buggy):

Image 2 is almost the same as in the book:

ch02b

Image 3, after changing samples per pixels to 100:

ch06a

Image 4, imperfect PDF

ch06c

Image 5, random_in_hemisphere, this is undefined in the book, btw. Anyway the result is strange...

ch06d

hollasch commented 4 months ago

This work should be accomplished as a result of #863.

dimitry-ishenko commented 2 months ago

When I change samples per pixel from 64 to 100 (as it is in listing 17) my image is still much noisier than Image 3. In my reimplementation 1000 gives the matching result.

Maybe this is an old issue, but Chapter 6.1 now says to increase number of samples per pixel to 1000:

Let’s adjust some parameters for the Cornell box:

 int main() {
     ...
+    cam.samples_per_pixel = 1000;
     ...
 }
dimitry-ishenko commented 2 months ago

The brighter image part is a dup of #1321. @hollasch this issue can technically be closed.