search

RayTracing / raytracing.github.io

Main Web Site (Online Books)
https://raytracing.github.io/
Creative Commons Zero v1.0 Universal
8.67k stars 852 forks source link

Book 3.3.5: Function parameters are used inconsistently #1531

Open dimitry-ishenko opened 5 months ago

dimitry-ishenko commented 5 months ago

In Chapter 3.5 we can't seem to settle on which letter to use as a parameter for the CDF and keep switching between $x$ and $r$. This is not a big deal, just a bit disorienting. Here is a sample:

Screenshot from 2024-04-15 22-28-51

This also occurs throughout other parts of the book, but just happened to catch my attention here.

hollasch commented 5 months ago

Moving into the v4.0.0 milestone for consideration. We may or may not punt this for the actual v4.0.0 release, depending on our progress.

hollasch commented 3 weeks ago

Note that this flipping between $x$ and $r$ is also reflected in accompanying figures.

hollasch commented 3 weeks ago

I think the problem here is that unfortunately P(r) refers to the PDF of one function, while P(x) is used to refer to a different function.

hollasch commented 3 weeks ago

I think that just renaming all P(r) to P(x) would create more confusion.

dimitry-ishenko commented 3 weeks ago

Another option maybe is to use a letter different from P for one of them? Just an idea.