search

RayTracing / raytracing.github.io

Main Web Site (Online Books)
https://raytracing.github.io/
Creative Commons Zero v1.0 Universal
8.72k stars 856 forks source link

1.9.1: Interval does not match 'cube enclosing the unit sphere'. #1603

Closed whydoubt closed 1 month ago

whydoubt commented 1 month ago

In #1591, text was changed from 'unit cube' to 'cube enclosing the unit sphere' to correctly describe the cube. At the same time, the range was changed to interval notation, and the values were changed (from -1 and +1 to 0 and 1). While I like the use of interval notation here, the values are now incorrect. x/y/z in the range [-1,1] is the actual range for a cube enclosing the unit sphere. x/y/z in the range [0,1] is (ironically?) a unit cube.

hollasch commented 1 month ago

Yup, the range should be $[-1,+1]$. Let me know if you want to make the PR, or I can do it.

whydoubt commented 1 month ago

You can go ahead with this one, I'm away from my workstation for a bit.

hollasch commented 1 month ago

Will do; thanks.