search

RayTracing / raytracing.github.io

Main Web Site (Online Books)
https://raytracing.github.io/
Creative Commons Zero v1.0 Universal
8.91k stars 883 forks source link

Book 2.5.5: Missing Removal of Code block #1660

Open beersandrew opened 1 week ago

beersandrew commented 1 week ago

In 2.5.1 (Using Blocks of Random Numbers), perlin.h is created with a private variable randfloat. This variable is removed in 2.5.5 in favor of randvec, however the code highlighting for deleting the existing lines with randfloat do not appear in the book.

I'm happy to create the PR for this work, but wanted to try to follow the contributing guidelines by posting this issue first to make sure this would be a useful fix.

hollasch commented 1 week ago

Sounds great, thanks for catching that. Please go ahead and create a PR against the dev-patch branch. Also remember to add a line to the CHANGELOG and add your name to books/acknowledgments.md.html.