Rayhane-mamah / Tacotron-2

DeepMind's Tacotron-2 Tensorflow implementation
MIT License
2.27k stars 905 forks source link

Test "python train.py --model='WaveNet' ", Assertion error. #132

Closed Yeongtae closed 6 years ago

Yeongtae commented 6 years ago

For testing, I use mulaw(8bit) and raw(16bit).

  1. After I have run 'Python wavenet_preprocess.py', I can get these files. image

  2. After I have run "Python train --model='WaveNet' " without any modification, I can see an error. image

It seems to be a problem because of a part of 'map.txt'. image

  1. Modifying 'hparams.py' to prevent the above error. image Though we use GTA mel files, we must set the parameter false. It's very weird.

  2. After I have run "Python train --model='WaveNet' with the modification, I can see an assertion error. image

Rayhane-mamah commented 6 years ago

Hello @Yeongtae, you make a point, documentation is missing the standalone Wavenet explanation, so let me put few notes here to explain quickly:

A quick personal POV while we're at it, if you want to make a 8-bit wavenet, I recommend going with mulaw-quantize instead of mulaw as it converges faster for about the same quality. :)

Rayhane-mamah commented 6 years ago

@Yeongtae, Just adding another note here because everyone seems to be having a confusion when it comes to GTA:

In T2 paper, it is mentioned in the line below: "We then train our modified WaveNet on the ground truth-aligned predictions of the feature prediction network."

Yeongtae commented 6 years ago

I accepted and applied your advice. But I can't fix it. image Errors always occur at the same location.

Yeongtae commented 6 years ago

After debugging, I could see the value of 298 which isn't 300. 300 is our hop size. image

In my opinion, there is a bug at the '_adjust_time_resolution' function in "wavenet_vocoder/feeder.py" image

Rayhane-mamah commented 6 years ago

This has been permanently fixed by going back to the source of the initial problem. I have manually tested GTA and no GTA synthesis of Wavenet on 4 different datasets without problem. For that matter I added a "test_wavenet_feeder.py" file to test all training files compatibilities prior to training.

If the issue is persistent, it's most likely due to a misuse of the model, please let me know how things go for you. (GTA synthesis has been changed so make sure to do that again if you try GTA training, it goes 40x faster than our previous implementation so it shouldn't be a problem to redo)

Feel free to reopen if it persists.