search

Raylehnhoff / Have-I-Cubed-This-Yet

A small tool to keep track of if something was cubed or not
11 stars 12 forks source link

add 2.4.1 items support #12

Closed VennieSo closed 8 years ago

VennieSo commented 8 years ago

Hi Raylehnhoff,

I've added 2.4.1 item updates, hope this is useful. I certainly found your tool to be very much so. Todo: update patch notice to offer season/non-season migration again.

Cheers, Vennie

Raylehnhoff commented 8 years ago

Hey, thanks. This is actually super helpful. I've been working a lot lately and haven't really had time for my pet projects. I'll need to setup the migration before I can merge this PR, though.

VennieSo commented 8 years ago

FYI I had to force push amended commit messages to keep my email address private, so timeline's a bit off. Hope that doesn't cause you problems.

Raylehnhoff commented 8 years ago

No problem, I'm going to review this tomorrow (5/30) and get it merged in. Thanks again for taking the time to do this.

Raylehnhoff commented 8 years ago

@vennieso -- I pushed these changes to the HICTY-Test site, along with the changes necessary to do the migration. Can you please check it out to make sure it's working as expected? I tested against my 2.4 data, but I like to get a few other verifications before I push the updates out.

Be sure to backup your HICTY settings prior to visiting.

VennieSo commented 8 years ago

@Raylehnhoff where can I find the HICTY-Test site?

Raylehnhoff commented 8 years ago

@vennieso http://raylehnhoff.github.io/HICTY-Test

VennieSo commented 8 years ago

@Raylehnhoff looks good on my 2.4 data as well!

Raylehnhoff commented 8 years ago

I didn't merge this directly, but used parts of it. Thanks for your help on this, and sorry for the extreme delay.