search

Raylehnhoff / SCFSD

Star Citizen Faction Ship Drawer
http://raylehnhoff.github.io/SCFSD/
MIT License
24 stars 8 forks source link

Sort by size does not work #84

Open NEOTRONICS opened 6 years ago

NEOTRONICS commented 6 years ago

Select different ships sorted by size, the sorting is not according to sizes, at least not always ( Used Browser: Opera 49 ).

NEOTRONICS commented 6 years ago

My mistake, had the function expected differently.

Raylehnhoff commented 6 years ago

@NEOTRONICS -- what was the expected behavior?

NEOTRONICS commented 6 years ago

I thought the ship list ( generated picture ) can be rearranged with this option, but it's just for the definition list. As written my fault, sorry :) .

Raylehnhoff commented 6 years ago

It re-arranges the fleet graphic AND the input list, but does so based on the size of the SVG and not necessarily the actual ships dimensions (though they should be pretty close)

Once it re-arranges the fleet graphic, you can generate a new png output.

I don't use Opera at all, and the generator is broken (in Firefox) due to a VERY longstanding bug in Firefox and the Canvas plugin I use.

If you're not seeing it re-organize the ship list, maybe give it a whirl in Chrome?

NEOTRONICS commented 6 years ago

No, that's not how it works for me ... fantastic ... browser support is a crazy thing :D.

If I have sorted by name and select the ships in the correct order everything is fine. So often i do not change the fleet, only in each concept Sale - almost X). Then a hint might not be bad for which browser this page is optimized/tested and good.

Raylehnhoff commented 6 years ago

Let's reopen this. I'll pull opera down this evening and see if I can fix it.

On Dec 16, 2017 3:31 PM, "NEOTRONICS" notifications@github.com wrote:

No, that's not how it works for me ... fantastic ... browser support is a crazy thing :D.

If I have sorted by name and select the ships in the correct order everything is fine. So often i do not change the fleet, only in each concept Sale - almost X). Then a hint might not be bad for which browser this page is optimized/tested and good.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Raylehnhoff/SCFSD/issues/84#issuecomment-352216525, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAvM7UE2HlCE1qwZn_qLx9bRgf7RjUWks5tBES4gaJpZM4REWaL .

Raylehnhoff commented 6 years ago

I downloaded Opera on Windows 10 with no plugins, and the sorting system is working as I'd expect it to, re-organizing both the input list and the ship list.

Can you please open the Opera dev tools (right click a page element->inspect element), click the console tab.

Refresh the page and re-sort a few times. In the developer tools window, if there are any console errors, please paste them in this thread.

Also, in the console, please type:

JSON.stringify(localStorage);

and hit enter. Please paste the output to this thread. This will let me test with the same ship inputs that you're using for the site and tell me if you encountered any errors along the way.

Also, what operating system are you using?