Fix for 'NOT A QUESTION's, Fix for game type check, updating README for python3.9, updating requirements to provide a 'fix' for aiocometd

Raymo111 / kahoot-answer-bot

A bot to win Kahoots

189 stars 130 forks source link

Fix for 'NOT A QUESTION's, Fix for game type check, updating README for python3.9, updating requirements to provide a 'fix' for aiocometd #33

Closed sealldeveloper closed 1 year ago

sealldeveloper commented 1 year ago

Fix NOT A QUESTIONS
Fix Game Type Check

Raymo111 commented 1 year ago

Also can you edit this PR and specify what exactly your changes are for (apart from the asyncio thing)?

sealldeveloper commented 1 year ago

Fixes the errors from the new NOT A QUESTION questions
Fixes the errors from the incorrect gameBlockType to type
Updated requirements to have an optional update to aiocometd
Fixed the README for Arch, re-added the text for other distros

Raymo111 commented 1 year ago

@sealldeveloper please use descriptive commit messages, and try to avoid editing the file directly on the GitHub web interface.

sealldeveloper commented 1 year ago

@sealldeveloper please use descriptive commit messages, and try to avoid editing the file directly on the GitHub web interface.

I don't understand, I've provided the issues that were fixed and updated the according files, what is the issue? Also, why avoid the web interface? I'm currently a little pressed for time and that was the quickest fix available.

sealldeveloper commented 1 year ago

If your talking about the 'Update [filename]', I listed the issues fixed below with the comment, apologies about the lack of detailed commits.

Raymo111 commented 1 year ago

The web interface makes it impossible to review your commits, since every commit is of an individual file and extremely undescriptive. If you're pressed for time, wait until you have more time instead of contributing sloppy changes. I'm also pressed for time. I have to review your code.

sealldeveloper commented 1 year ago

I will recreate this pull with better detail.