Closed sealldeveloper closed 1 year ago
Also can you edit this PR and specify what exactly your changes are for (apart from the asyncio thing)?
NOT A QUESTION
questionsgameBlockType
to type
aiocometd
@sealldeveloper please use descriptive commit messages, and try to avoid editing the file directly on the GitHub web interface.
@sealldeveloper please use descriptive commit messages, and try to avoid editing the file directly on the GitHub web interface.
I don't understand, I've provided the issues that were fixed and updated the according files, what is the issue? Also, why avoid the web interface? I'm currently a little pressed for time and that was the quickest fix available.
If your talking about the 'Update [filename]', I listed the issues fixed below with the comment, apologies about the lack of detailed commits.
The web interface makes it impossible to review your commits, since every commit is of an individual file and extremely undescriptive. If you're pressed for time, wait until you have more time instead of contributing sloppy changes. I'm also pressed for time. I have to review your code.
I will recreate this pull with better detail.