RaymondBalise / rUM

r template for RStudio from your friends at the University of Miami.
https://raymondbalise.github.io/rUM/
Other
8 stars 3 forks source link

Change imports to be suggests #51

Closed RaymondBalise closed 5 months ago

RaymondBalise commented 7 months ago

The run me first program had package imports for many things. These should just be suggests because the packages are just used in the vignette.

gabrielodom commented 7 months ago

I'm confused. I thought we were making changes to the @Imports and @Suggests field. Where are the changes?

gabrielodom commented 7 months ago

NOTE on Windows:

checking dependencies in R code ... NOTE
  Namespaces in Imports field not imported from:
    'here' 'roxygen2'
    All declared Imports should be used.

Where do we use these packages? If it's not in the package, it probably goes in @Suggests.

kyleGrealis commented 7 months ago

here and roxygen2 are used when the new rUM project is being converted to it's own package for portability on the 3rd person's machine. i hope that's a coherent explanation. i, kyle, make a new academic paper. i bundle it as a package. i sent to you, Gabriel, not assuming that you already have these packages. you install my new project package and the world rejoices without errors... hopefully

RaymondBalise commented 6 months ago

I think this release is good to go to CRAN. Please test make some projects and check the documentation.

gabrielodom commented 6 months ago

It still opens two duplicate RStudio windows. Any idea on what causes this?

RaymondBalise commented 6 months ago

I have never seen this. What OS?

Ray

Sent from my iPhone

On May 29, 2024, at 3:52 PM, Gabriel J. Odom @.***> wrote:

 CAUTION: This email originated from outside the organization. DO NOT CLICK ON LINKS or OPEN ATTACHMENTS unless you know and trust the sender.

It still opens two duplicate RStudio windows. Any idea on what causes this?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/RaymondBalise/rUM/pull/51*issuecomment-2138155994__;Iw!!KVu0SnhVq1hAFvslES2Y!K-XudFaIOwKa0x_NavdTlkPiaYg7xv4D64UDZHR1cczGAEssSMfNOoO8esI1nx9c8X4xaZL2Rbv0dytAmUMuLAs$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEKOXORVZRDJHZI6YKWETN3ZEYWZJAVCNFSM6AAAAABGSZBOFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGE2TKOJZGQ__;!!KVu0SnhVq1hAFvslES2Y!K-XudFaIOwKa0x_NavdTlkPiaYg7xv4D64UDZHR1cczGAEssSMfNOoO8esI1nx9c8X4xaZL2Rbv0dytAXBJZ16o$. You are receiving this because you authored the thread.Message ID: @.***>

gabrielodom commented 6 months ago
sessionInfo()
R version 4.4.0 (2024-04-24)
Platform: x86_64-apple-darwin20
Running under: macOS Monterey 12.7.5

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 
LAPACK: /Library/Frameworks/R.framework/Versions/4.4-x86_64/Resources/lib/libRlapack.dylib;  LAPACK version 3.12.0

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

time zone: America/New_York
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
[1] compiler_4.4.0    tools_4.4.0       rstudioapi_0.16.0
gabrielodom commented 5 months ago

Link to #52