search

Raynes / fs

File system utilities for Clojure.
453 stars 119 forks source link

Additional Functions #23

Closed wwentland closed 12 years ago

wwentland commented 12 years ago

Hi Raynes,

I would be happy if you could merge these functions into fs-proper, as I use them in a couple of projects and find them quite useful. find-files' functionality might overlap with glob, but I find its implementation and interface to be saner and generally prefer this approach.

Thank you

Raynes commented 12 years ago

These look fine, but you need to use the file function in fs.core. It has some special behavior that makes it adhere to a 'current working directory'. Also, what is the point of join? Since io/file and fs.core/file can do that, I'm not sure how useful it is. The only difference here is that it returns the path as a string, right? I think there is a function in fs that wraps .getPath. If so, you could put that and file together and replace this function.

I definitely what find-files and absolute?. It just seems like join is a little redundant.

wwentland commented 12 years ago

I incorporated your suggestion to use fs.core/file and also changed find-files to return java.io.Files instead of strings/paths.