search

Raynes / fs

File system utilities for Clojure.
453 stars 119 forks source link

should be able to detect links #48

Closed bwo closed 11 years ago

bwo commented 11 years ago

and specify whether or not to follow them for e.g. directory?.

tbatchelli commented 11 years ago

This change makes 'fs' dependent on Java 7 :( as java.nio.file is not present in Java6 and older.

Raynes commented 11 years ago

Yep, that's intentional @tbatchelli

tbatchelli commented 11 years ago

OK, I wasn't sure if this was the goal, as the README say Java7 is required.

On Sep 9, 2013, at 2:38 PM, Anthony Grimes notifications@github.com wrote:

Yep, that's intentional @tbatchelli

— Reply to this email directly or view it on GitHub.

Antoni Batchelli Founder palletops.com

Raynes commented 11 years ago

@tbatchelli Do you mean that the README should say that Java 7 is required? The reason that it doesn't at the moment is because @noprompt made a couple of other commits to fix fs to not require java 7 until we do a major version inc. Are you sure you've got the latest version?

tbatchelli commented 11 years ago

I thought you said that it was intentional to require Java7.

I am using 1.4.4, and I see this is fixed in master now...

Toni. On Sep 9, 2013, at 2:42 PM, Anthony Grimes notifications@github.com wrote:

@tbatchelli Do you mean that the README should say that Java 7 is required? The reason that it doesn't at the moment is because @noprompt made a couple of other commits to fix fs to not require java 7 until we do a major version inc. Are you sure you've got the latest version?

— Reply to this email directly or view it on GitHub.

Antoni Batchelli Founder palletops.com

Raynes commented 11 years ago

@tbatchelli I'm being cryptic. Sorry. Here's how it went down:

@noprompt Made those commits to add those features and such, but he didn't realize at the time that it made fs dependent on Java 7. I accepted the pull request knowing it'd break Java 7 support, but absentmindedly pushed a not-major version increment which broke everything for people not using Java 7. We fixed this promptly by releasing a new version, 1.4.5, that conditionally defines these things based on whether or not Java 7 is available.

However, doing this conditional stuff is a real pain in the ass, so with the next major version we will very likely remove support for Java < 7 entirely because nio has tons of helpful stuff we can make use of.

tbatchelli commented 11 years ago

@raynes Thanks for clarifying. I didn't realize there was a 1.4.5 version out there, which should work for us :)

Toni.

On Sep 9, 2013, at 2:50 PM, Anthony Grimes notifications@github.com wrote:

@tbatchelli I'm being cryptic. Sorry. Here's how it went down:

@noprompt Made those commits to add those features and such, but he didn't realize at the time that it made fs dependent on Java 7. I accepted the pull request knowing it'd break Java 7 support, but absentmindedly pushed a not-major version increment which broke everything for people not using Java 7. We fixed this promptly by releasing a new version, 1.4.5, that conditionally defines these things based on whether or not Java 7 is available.

However, doing this conditional stuff is a real pain in the ass, so with the next major version we will very likely remove support for Java < 7 entirely because nio has tons of helpful stuff we can make use of.

— Reply to this email directly or view it on GitHub.

Antoni Batchelli Founder palletops.com