Define fns for Java 7 conditionally

Raynes / fs

File system utilities for Clojure.

453 stars 119 forks source link

Define fns for Java 7 conditionally #55

Closed noprompt closed 11 years ago

noprompt commented 11 years ago

This fixes the problems with breaking compatibility mentioned in #54.

Raynes commented 11 years ago

The tests are also going to fail on java 7. Also, did you test on java 6 to make sure this works properly? Pretty sure it does, but never hurts to test.

noprompt commented 11 years ago

... and five days later. Sorry for the lag. I know, I know, I'm fired right?

cldwalker commented 11 years ago

This resolves the exception I was getting in java 6: ClassNotFoundException java.nio.file.Files java.net.URLClassLoader$1.run (URLClassLoader.java:202) so :thumbsup: .lein test passes as well.

May be worth adding jdk6 and jdk7 to your travis.yml e.g. like this

Raynes commented 11 years ago

Pushed 1.4.5.

Note however that we're likely going to remove 1.6 support personally in 2.0 because this is an ugly hack.

cldwalker commented 11 years ago

Cool. It may be worth putting in a deprecation notice when 2.0 comes up.