Raynes / fs

File system utilities for Clojure.
453 stars 119 forks source link

commons-compress 1.4 -> 1.8 #77

Closed aphyr closed 10 years ago

aphyr commented 10 years ago

There aren't any tests for this library, so I'm not sure how to figure out if this change is safe. Suggestions?

aphyr commented 10 years ago

Specifically, I'm kinda puzzled by

kingsbury@hackbook:~/fs master$ lein midje
Exception in thread "main" java.lang.NullPointerException
    at user$eval35.invoke(NO_SOURCE_FILE:1)
    at clojure.lang.Compiler.eval(Compiler.java:6511)
    at clojure.lang.Compiler.eval(Compiler.java:6500)
    at clojure.lang.Compiler.eval(Compiler.java:6500)
    at clojure.lang.Compiler.eval(Compiler.java:6477)
    at clojure.core$eval.invoke(core.clj:2797)
    at clojure.main$eval_opt.invoke(main.clj:297)
    at clojure.main$initialize.invoke(main.clj:316)
    at clojure.main$null_opt.invoke(main.clj:349)
    at clojure.main$main.doInvoke(main.clj:427)
    at clojure.lang.RestFn.invoke(RestFn.java:421)
    at clojure.lang.Var.invoke(Var.java:419)
    at clojure.lang.AFn.applyToHelper(AFn.java:163)
    at clojure.lang.Var.applyTo(Var.java:532)
    at clojure.main.main(main.java:37)
Subprocess failed
kingsbury@hackbook:~/fs master$ lein test

lein test me.raynes.core-test

Ran 0 tests containing 0 assertions.
0 failures, 0 errors.
Raynes commented 10 years ago

Well there are definitely tests for this library. Why lein midje is failing eludes me, but I'm pretty sure the output you got from lein test is expected when you use midje. If there were any failures you would have seen them in the output.

That said, I'll take a look later tonight.

Raynes commented 10 years ago

Or two weeks later. You never know.

https://dl.dropboxusercontent.com/s/3yh6yxyl5wup43c/2014-04-22%20at%209.36%20AM.png'

I've got no idea why lein midje wasn't working for you. Perhaps leiningen version mismatch? :(

In any case, thanks for the pull request and apologies for taking so long to merge it.