search

Raynes / laser

HTML transformation/templating for people who do that sort of thing and stuff
120 stars 16 forks source link

:xml parsing should allow XML declaration #26

Closed terjesb closed 11 years ago

terjesb commented 11 years ago

I found another issue with the XML support. It doesn't like the XML declaration (encoding declaration omitted in this example):

(l/document (l/parse "<?xml version=\"1.0\"?><root/>" :xml))

IllegalArgumentException No implementation of method: :as-hickory of protocol: #'hickory.core/HickoryRepresentable found for class: org.jsoup.nodes.XmlDeclaration clojure.core/-cache-protocol-fn (core_deftype.clj:541)

Raynes commented 11 years ago

Yeah, I know what's causing this and it shouldn't be particularly hard to fix.

Raynes commented 11 years ago

Going to fix this and the other XML issue tomorrow. Sorry it has taken so long. I was in the middle of some breaking changes and wanted to get them all done before I did this excuse excuse more excuses etc etc.

Commenting here so that I have motivation to fix these things tomorrow for real, because now I'll look like an asshat if I don't.

Raynes commented 11 years ago

Fixed in the latest commit and will be in the next version.