Raynes / lein-bin

Standalone console executables for your project.
155 stars 19 forks source link

Support extra java arguments via JVM_OPTS environment variable #14

Closed guns closed 10 years ago

guns commented 11 years ago

cf. Issue #13

Took me a moment to write it, then like an hour of trying to boot an old Windows VM to test it before giving up. Points for trying?

Raynes commented 11 years ago

No problem, I have bootcamp. Might be a bit before I can test it though. I don't even have lein installed on it.

On Thu, May 23, 2013 at 8:10 PM, Sung Pae notifications@github.com wrote:

cf. Issue #13 Took me a moment to write it, then like an hour of trying to boot an old Windows VM to test it before giving up. Points for trying? You can merge this Pull Request by running: git pull https://github.com/guns/lein-bin JVM_OPTS Or you can view, comment on it, or merge it online at: https://github.com/Raynes/lein-bin/pull/14 -- Commit Summary --

guns commented 10 years ago

Revisited this today, and realized that I can embed environment variables into the :jvm-opts project entry:

:jvm-opts ~(if-let [jvm-opts (System/getenv "JVM_OPTS")]
             (clojure.string/split jvm-opts #"\s+")
             [])

Therefore there is no need for direct support. Thanks!