search

Raynos / dom-delegator

Decorate elements with delegated events
MIT License
58 stars 16 forks source link

cuid recent update breaks browserify #24

Open panthershark opened 8 years ago

panthershark commented 8 years ago

The cuid package was updated to 1.3.0 today with some kind of breaking change which it breaks the ability to browserify. I am running mercury.js for my build. This PR changes cuid dependency from caret to tilde so we can take the time to figure out why cuid breaks.

Would you accept this PR and publish a patch version of dom-delegator please?

events.js:141
      throw er; // Unhandled 'error' event
            ^
Error: Cannot find module 'cuid' from '/Users/tommy/src/cbanc/cbw/node_modules/mercury/node_modules/dom-delegator'
    at /Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:46:17
    at process (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)
    at ondir (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)
    at load (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
    at /Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:82:15)
panthershark commented 8 years ago

Looks like it is reported over here - https://github.com/ericelliott/cuid/issues/42

ericelliott commented 8 years ago

cuid fix incoming.

nikuda commented 8 years ago

I'd suggest locking down all dom-delegator deps to patch versioning ~, or even better, have them all fixed to a version.

ericelliott commented 8 years ago

Generally a good idea.

panthershark commented 8 years ago

@nikuda - agree.

@ericelliot - thanks for being so responsive :)

ericelliott commented 8 years ago

:+1: