hg.partial on server-side - Githubissues

Raynos / mercury

A truly modular frontend framework

http://raynos.github.io/mercury/

MIT License

2.82k stars 142 forks source link

hg.partial on server-side #121

Closed NeCkEr closed 9 years ago

NeCkEr commented 9 years ago

can't get hg.partial to work on server-side rendering...

any suggestions?

Raynos commented 9 years ago

We use virtual-dom-stringify ( https://github.com/Raynos/mercury/blob/master/examples/server-rendering/server.js#L6 ) on the server.
The source code is here ( https://github.com/alexmingoia/virtual-dom-stringify )
hg.partial generates a thunk ( https://github.com/Raynos/vdom-thunk/blob/master/immutable-thunk.js ).
virtual-dom-stringify is missing an else if (isThunk(node)) block ( https://github.com/alexmingoia/virtual-dom-stringify/blob/master/lib/stringify.js#L110 )

If you make a PR on virtual-dom-stringify to stringify thunks ( and add tests! ) then it should work.