Closed joshgillies closed 9 years ago
lgtm. Maybe pass in an immutable object instead of calling .toJS()
Thanks, I too noted this right after submitting the PR. :(
As such I already have a cut of what you're proposing locally, will push these changes soon. On 5 Feb 2015 5:07 am, "Raynos (Jake Verbaten)" notifications@github.com wrote:
lgtm. Maybe pass in an immutable object instead of calling .toJS()
— Reply to this email directly or view it on GitHub https://github.com/Raynos/mercury/pull/127#issuecomment-72906099.
Updated. Take a look and let me know if there's anything else.
@joshgillies looks legit. #nicework
First attempt at using Facebook's
immutable
library in place ofobserv-*
.Ping #75