search

Raynos / mercury

A truly modular frontend framework
http://raynos.github.io/mercury/
MIT License
2.82k stars 142 forks source link

Examples npm script fixed. #141

Closed lucianlature closed 9 years ago

lucianlature commented 9 years ago

Fixed a bug where each example was undefined in content due to not correctly being set.

Raynos commented 9 years ago

This depends completely on the version of routes-router.

Can you npm install routes-router --save and update the package.json & verify it again ?

lucianlature commented 9 years ago

Installed the latest version of routes-router initially and this is how I've noticed the bug in the first place. So, yes, I've verified it again and it needs opts.params.name instead of opts.name.

Raynos commented 9 years ago

The latest version of routes-router is version 4. Can you update the package.json ?

lucianlature commented 9 years ago

@Raynos: Since https://github.com/Raynos/routes-router is deprecated, wouldn't be beneficial on the longer term to use https://github.com/Matt-Esch/http-hash-router instead?

kuraga commented 9 years ago

Yes and remove examples/lib/router.

Raynos commented 9 years ago

@lucianlature yeah, feel free to fix that in this PR or in another PR.

Refactoring examples/lib/router into mercury-router is out of scope for this PR, but feel free to open a seperate PR for that.

kumavis commented 9 years ago

@lucianlature is this PR good to go?

lucianlature commented 9 years ago

@kumavis: Yep :+1:

Raynos commented 9 years ago

if it works then #coolstory #shipit