search

Raynos / mercury

A truly modular frontend framework
http://raynos.github.io/mercury/
MIT License
2.82k stars 143 forks source link

Add missing jquery dep for example #193

Closed aredridel closed 8 years ago

Raynos commented 8 years ago

This is a good joke. I appreciate this.

aredridel commented 8 years ago

The example does require it :)

Raynos commented 8 years ago

Which one :( I'm pretty sure we only use virtual-dom or React in examples.

aredridel commented 8 years ago

Okay now I feel like I'm going crazy. I tracked this down but now it's working. Well then sorry for the noise.

Raynos commented 8 years ago

No worries; thanks for opening a PR though.

ghost commented 8 years ago

@Raynos @aredridel There is an example that requires jquery, at least indirectly. It looks like it's the backbone example. When I run npm run build:

 npm run build

> mercury@14.0.0 build /home/colin/mercury
> node bin/build.js

reading /home/colin/mercury/examples/geometry/browser.js
reading /home/colin/mercury/examples/todomvc/browser.js
reading /home/colin/mercury/examples/markdown/browser.js
reading /home/colin/mercury/examples/number-input/browser.js
reading /home/colin/mercury/examples/unidirectional/backbone/browser.js
reading /home/colin/mercury/examples/unidirectional/jsx/browser.js
reading /home/colin/mercury/examples/unidirectional/immutable/browser.js
reading /home/colin/mercury/examples/login-form/browser.js
reading /home/colin/mercury/examples/bmi-counter.js
reading /home/colin/mercury/examples/shared-state.js
reading /home/colin/mercury/examples/count.js
reading /home/colin/mercury/examples/canvas.js
reading /home/colin/mercury/examples/async-state.js
reading /home/colin/mercury/examples/real-dom.js
events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: module "jquery" not found from "/home/colin/mercury/node_modules/backbone/backbone.js"
    at notFound (/home/colin/mercury/node_modules/browserify/index.js:803:15)
    at /home/colin/mercury/node_modules/browserify/index.js:754:23
    at /home/colin/mercury/node_modules/browserify/node_modules/browser-resolve/index.js:185:24
    at /home/colin/mercury/node_modules/browserify/node_modules/resolve/lib/async.js:44:14
    at process (/home/colin/mercury/node_modules/browserify/node_modules/resolve/lib/async.js:113:43)
    at /home/colin/mercury/node_modules/browserify/node_modules/resolve/lib/async.js:122:21
    at load (/home/colin/mercury/node_modules/browserify/node_modules/resolve/lib/async.js:54:43)
    at /home/colin/mercury/node_modules/browserify/node_modules/resolve/lib/async.js:60:22
    at /home/colin/mercury/node_modules/browserify/node_modules/resolve/lib/async.js:16:47
    at FSReqWrap.oncomplete (fs.js:82:15)

npm ERR! Linux 4.2.5-1-ARCH
npm ERR! argv "/home/colin/.nvm/versions/node/v4.2.1/bin/node" "/home/colin/.nvm/versions/node/v4.2.1/bin/npm" "run" "build"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! code ELIFECYCLE
npm ERR! mercury@14.0.0 build: `node bin/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the mercury@14.0.0 build script 'node bin/build.js'.
npm ERR! This is most likely a problem with the mercury package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node bin/build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls mercury
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/colin/mercury/npm-debug.log
aredridel commented 8 years ago

YES! That was it!

Raynos commented 8 years ago

Oh I see; looks like we do need jquery (backboooooooooooone).

Raynos commented 8 years ago

We can add that to dev deps.

Raynos commented 8 years ago

Our friend @coballast fixed this :) thanks.