search

Raynos / min-document

A minimal DOM implementation
MIT License
109 stars 27 forks source link

Add element.contains method #29

Closed bendrucker closed 8 years ago

mwiencek commented 8 years ago

LGTM but might as well add it to the document prototype too?

> document.contains(document.body)
true
bendrucker commented 8 years ago

Right, good call! Added a ref to the document prototype as well as a corresponding test.

mwiencek commented 8 years ago

Awesome, looks identical to a patch I had in my fork but never got around to adding tests for. :+1:

bendrucker commented 8 years ago

Awesome! Lemme know when you have a chance to publish to npm.

mwiencek commented 8 years ago

You'll have to bug @Raynos for that :smile:

bendrucker commented 8 years ago

Can we throw in https://github.com/Raynos/value-event/pull/21 too? ;)