search

Rayquaza01 / authenticator

Firefox addon that generates TOTPs for 2 factor authentication
https://addons.mozilla.org/en-US/firefox/addon/two-factor-authenticator/
MIT License
34 stars 7 forks source link

The password is in clear when unlock the addon on firefox #23

Open rgiordani71 opened 5 years ago

rgiordani71 commented 5 years ago

Bug Report

Please fill out this information:

Before the update the password to unlock the OTP registered was hidden with *, now the password is in clear when I enter it

What are the steps to reproduce the bug?

Open the browser console (Hamburger menu > Web Developer > Browser Console) and include anything that is logged when the bug occurs.
This step is not always necessary.

Any screenshots or videos of the bug would be helpful.

Rayquaza01 commented 5 years ago

Hello, this is actually the inverse of the problem in #16. Essentially, on Linux, password fields inside of extension popups cause the popup to automatically close. This is a bug in Firefox. As a quick fix, I changed the password field to a normal text field to prevent the extension from breaking on Linux until I could figure out a better solution.

Rayquaza01 commented 5 years ago

Hello, I've fixed this in v1.3.2. It should now hide the password again (except on linux, where it will still show the password).

rgiordani71 commented 5 years ago

Tx

Sent from my iPhone

On 12 Dec 2018, at 02:11, Rayquaza01 notifications@github.com wrote:

Hello, I've fixed this in v1.3.2. It should now hide the password again (except on linux, where it will still show the password).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Mebus commented 5 years ago

Hello, I've fixed this in v1.3.2. It should now hide the password again (except on linux, where it will still show the password).

On Linux it still show's the password. Why wasn't this fixed?

Mebus

Rayquaza01 commented 5 years ago

@Mebus There was a bug in Firefox a while back that caused extensions with password inputs in their popups to close immediately on Linux (see #16). I added a workaround to make the extension actually usable. The bug in Firefox seems to be fixed now though, so the workaround will be removed in the next version, which I will hopefully finish soon.

felsgaertner commented 3 years ago

I have Firefox 87 on Linux Mint 20.1. With add-on version 1.3.2 it is still clear text password entry.

roncro commented 3 years ago

I am using RHEL 8.3, firefox 78.10.0esr (64-bit). I also see the clear password, and also it seems to not generate the correct MFA code? (compared to a phone app, which does generate the correct code)

mrx23dot commented 3 weeks ago

No issue on Firefox 115 on Windows.