search

Rayquaza01 / authenticator

Firefox addon that generates TOTPs for 2 factor authentication
https://addons.mozilla.org/en-US/firefox/addon/two-factor-authenticator/
MIT License
34 stars 7 forks source link

Keep the browser default font #7

Closed nebulade closed 7 years ago

nebulade commented 7 years ago

At least on my setup when changing between different dpi displays (external/laptop) this somewhat gets into the way of firefox changing the font size. It looks way to big on my hidpi screen, when the font is set specifically.

Rayquaza01 commented 7 years ago

On my end, simply removing the font size will make it too small. How did it look before v1.0.5 when the font size was defined in terms of pixels?

body {
    font-family: monospace;
    font-size: 20px;
}
nebulade commented 7 years ago

Both 20px and 1.5rem appear mostly at the same size, which is for me way too big in comparison with any other UI elements. Maybe that is fully intentional though and I just mistake that for a font size bug.

For me this looks like this: screenshot from 2017-11-07 20-35-18

Rayquaza01 commented 7 years ago

That was intentional, though I never put much thought into how big the text in other UI elements are. Apparently, the default font size for monospace is 13px while everything else is 16px so I ended up overcompensating with 20px. I think monospace 16px is a fair size that's smaller, but still more legible than 13px.

nebulade commented 7 years ago

Ah I didn't realize the monospace default is indeed so small, I checked and saw that i explicitly increased that locally in my ff setup even. The compromise on 16px does look much better for me, so I would be happy if that would be done. I will close this now as I guess it is easier if you just push a commit if you agree with the 16px.