Rayquaza01 / note-taker

A Firefox addon that adds a text box to a toolbar button for taking notes.
MIT License
28 stars 4 forks source link

Request : General Notes - Tab View #5

Closed hedgieinsocks closed 6 years ago

hedgieinsocks commented 6 years ago

It would be awesome if General Notes view was splitted into 4/5 horizontal tabs, and one could switch between them. The concept of site notes is fine, but having everything in one place is another level. Anyway, keep it up! Good job.

Rayquaza01 commented 6 years ago

Sorry for not getting to this sooner.

A tab strip has been added in the latest version (1.2.0) released today. It can be enabled by setting the "Number of Tabs" option to how many tabs you want. The tab strip appears on all types of notes (Domain, URL, and General), not just General Notes.

ngtinsmith commented 6 years ago

Default tab(1)'s notes disappears when switching from Tab1 -> Tab2 -> Tab1. Only shows again after you reopen the Extension (click somewhere else to close the popup, then open the popup notes again).

Also, a feature to change the Tab names would be nice too. Good work so far, keep it up!

mstar46 commented 6 years ago

Hello to all! I just installed note-taker and I have a few questions:

mstar46 commented 6 years ago

I am a little disappointed not to receive help ... After many tries I managed to display my three tabs in general mode. This is a partial answer to my second question, but new questions raise:

Rayquaza01 commented 6 years ago

@mstar46
Sorry about that. I haven't been able to reproduce the extra scroll bars in the popup or the export button only saving options.

Your first new point is a bug. I'll put out an update to fix it soon.
The red underline is Firefox's default spell check. You can right click a word and click "Add to Dictionary" to remove the underline from that word.
On your last point, I can't reproduce copying the text from the popup with incorrect horizontal spacing.

What is your Firefox version and OS? Can you upload one of the exported options files? These might be helpful in reproducing the issues you're having.

Sorry, again, for not responding earlier.

mstar46 commented 6 years ago

Thanks for your quick answer.

On my web site http://maths.ac-noumea.nc/polyhedr/index_.htm I use hundreds of Java animations and unfortunately most browsers don't support Java applets any longer; only Firefox ESR, MSIE (Windows) and Safari (Mac) still display them. That's why I presently use Firefox ESR 52.9.0 (32 bits) until the LiveGraphics3D applet will be translated from Java to JavaScript. Do you suspect the version of Firefox? I use it on Win 7 and Win 10 and have the same behaviour.

Rayquaza01 commented 6 years ago

OK, so the extra scrollbars were apparently a bug with how flex was handled. It's present on up to FF61. Essentially, the tabstrip and bottom buttons were taller than they should have been and added extra scrollbars.

The reason no context menu appears when you right click a word with red underline is because that was added after version 52. But judging by how many red underlines there are under real words, I think there may be something wrong with Firefox's dictionary. Installing a new dictionary might fix that issue.

Onto why the horizontal spacing changes when you copy it somewhere else. If you want to preserve horizontal spacing, you need to make sure that you use the same font settings in Notepad and Note Taker. Notepad uses a monospaced font by default, and Note Taker uses a proportional font by default. Setting both Notepad and Note Taker to the same font settings should fix the issue.

I still haven't been able to reproduce the notes not exporting with the options. Clearly, the notes are saving because it was in the attached storage.js. You can see the export code here. It just stringifies the storage and sets it to a link. I don't really get how that can be broken for you, but not the rest of it. Do you have storage issues with other webextensions? Does it happen in a new profile/fresh install?

mstar46 commented 6 years ago
Rayquaza01 commented 6 years ago

@mstar46 I'm not really sure why the problem would still be there in a new profile, or why it would only work for the first 75%. As a stopgap, I added a textbox on the options page that contains the raw JSON for the storage. I hope that it works for you.

Also, I'm sorry to be the bearer of bad news, but the next version of Firefox ESR is 60, not 53. According to the ESR website, 52 ESR won't be supported after September 5, 2018.

mstar46 commented 6 years ago

@Rayquaza01 Strangely again now the export works well! why didn't it before? mysterious... Concerning Firefox ESR you are right; I forgot that version 52 will be the last which supports java plug-in. I hope that the javascript version of LiveGraphics3D will be soon available. Thanks for sharing your nice work.