Closed brendonofficial closed 7 months ago
Thank you very much for your contribution. The one thing I am not sure of is asp-action vs asp-page. asp-action seems to work well. Is there a bug you noticed?
@apexdodge ah, my apologies, this is supposed to be asp-route
not asp-page
. I have updated the PR.
Using asp-route
here follows in line with other references to named routes within the codebase. Alternatively, asp-controller="EmailTemplates" asp-action="Index"
would be used instead, but asp-action="EmailTemplatesIndex"
won't work here as there is no such controller action named the same.
@brendonofficial Thank you for your contribution! This will be released with v1.1.4.
This PR fixes some minor code issues that I had noticed when cloning the repository.
Additionally, adding
.idea
to gitignore for those Rider users out there 😎