search

RaythaHQ / raytha

Raytha is a powerful CMS with an easy-to-use interface and fast performance. It offers custom content types, a template engine, and various access controls. It supports multiple storage providers and an automatically generated REST API. Upgrade your development workflow with Raytha.
MIT License
143 stars 30 forks source link

Create account crash on empty password #153

Closed apexdodge closed 7 months ago

apexdodge commented 7 months ago

In the Create Account screen, if the user enters a password that is at least 1 character, but less than the min password length, they are presented with an error. This behavior is correct.

However, if the user creates an account with a totally empty password field, then it crashes. We should be presented with the same error as the above.

Login.Commands.CreateUser

This if-statement should check for null || < than pw length.

apexdodge commented 7 months ago

This too: https://github.com/RaythaHQ/raytha/blob/87eedd10d63db398f4817c705dd07f5bb83cd43f/src/Raytha.Application/Login/Commands/CompleteForgotPassword.cs#L33

takuabonn commented 7 months ago

hi @apexdodge

I want to work in this issue. will u assign it to me?

apexdodge commented 7 months ago

@takuabonn Yes you are assigned now, thank you!

takuabonn commented 7 months ago

hi @apexdodge

please check below pull request. 🙇 #153

apexdodge commented 7 months ago

Thank you! This was merged with the dev branch and will be released with v1.1.4.