RaythaHQ / raytha

Raytha is a powerful CMS with an easy-to-use interface and fast performance. It offers custom content types, a template engine, and various access controls. It supports multiple storage providers and an automatically generated REST API. Upgrade your development workflow with Raytha.
MIT License
164 stars 31 forks source link

CONVERT(datetime) in sql missing specified format for order by #215

Closed apexdodge closed 1 month ago

apexdodge commented 2 months ago

Our JsonQueryEngine converts datetimes correctly for search / select clause.

But for order by, we have this line:

https://github.com/RaythaHQ/raytha/blob/c5a74ae2e9dbdd71c6956e78352c06b0bd0a0b6d/src/Raytha.Infrastructure/JsonQueryEngine/RaythaDbJsonQueryEngine.cs#L472

I'm expecting to see this parameter:

image

Without it, sql defaults to the system format, which might be different than the one selected by the admins? Could potentially result in incorrect sort order. It might be working fine, but investigation is needed.