search

Raytwo / Cobalt

Modding dependency for Fire Emblem Engage
40 stars 3 forks source link

New AssetTable entries inserted at lower line numbers than in the .xml patch. #22

Closed ltranc closed 1 year ago

ltranc commented 1 year ago

System Firmware Version

Ryujinx 1.1.969

Atmosphere Version

Ryujinx

Details

Inserted entries in the AssetTable appear to be inserted at lower line numbers than their location in the AssetTable.xml patch. Causes some minor visual issues with certain lines' changes and additions being overridden.

Examples

The following 3 examples are taken from Reverse Recruitment, no other mods were loaded. vision Illusory Doubles (first line) entry nulls all accessories, the following two entries, which were added and inserted, give Illusory Doubles summoned by Corrupted units the Corrupted headwear. Placed underneath the default Illusory Double accessory nulling entry, so that it would add on the helmet after it gets nulled. ryujinx_capture_2023-02-25_17-08-07 This had previously worked. ryujinx_capture_2023-08-07_17-19-39 At some point, AssetTable.xml patching was modified, making it no longer work.

shield The bottom two lines grant Ch17 and Ch19 Marni the Warrior bow animation while wielding Parthia, and null her shield accessory. Placed underneath her default class General entry that assigns the shield, so that it would null the shield. ryujinx_capture_2023-04-29_14-52-31 Previously, nulling the shield had worked. ryujinx_capture_2023-08-07_17-22-57 Placing the entry that nulls the shield at that line no longer works.

goldmary The third entry is a new line which assigns Goldmary's Hero outfit and scaling to the Sword Fighter class. ryujinx_capture_2023-08-07_17-15-08 ryujinx_capture_2023-08-07_17-15-57 A bit crude but, due to being inserted above where it should, the Sword Fighter model uses Goldmary's default VolumeBust value of 1.75, rather than the Hero outfit's value of 2.2.

DogeThis commented 1 year ago

Cobalt version is Version 0.22.3 for this issue.

DogeThis commented 1 year ago

Crashing issue fixed in 0.24.0 https://ptb.discord.com/channels/608790115002875934/1129754170208043028/1141103798652244189

Line number issue persists.

ltranc commented 1 year ago

https://www.dropbox.com/scl/fi/u4hasepgfzi093q0ndaqd/AssetTable.xml?rlkey=io7c5e3rgkp1rconj0lmdnklh&dl=0 https://www.dropbox.com/scl/fi/rbqi9ofo213j4fvpi4u37/AssetTablePatched.xml?rlkey=j8go64mmirgzqklxlellmk188&dl=0 First link is the AssetTable patch used, second link is the patched AssetTable in engage_patches. It appears that the entry is inserted at the correct line if the line directly above is edited in some way (or if multiple entries are inserted consecutively, if the line above the first addition is edited).

DogeThis commented 1 year ago

Verbal confirmation of fix. https://ptb.discord.com/channels/608790115002875934/1065612171578462278/1148731380193308702