Rayzeq / quick-settings-audio-panel

An gnome shell extension to add a new panel to the Quick Settings for sound related stuff
https://extensions.gnome.org/extension/5940/quick-settings-audio-panel/
GNU General Public License v3.0
80 stars 8 forks source link

Devices sliders not vanishing #35

Closed myryk31415 closed 9 months ago

myryk31415 commented 9 months ago

When toggling the option "Create per-device volume sliders", the sliders appear but dont disappear again. If you turn it back on the sliders appear twice, the three times etc. Removing the extension doesn't remove the sliders either, login out and back removed the sliders.

I am on: OpenSUSE Tumbleweed Gnome 45

Rayzeq commented 9 months ago

I don't have this issue on my end. Could you send the list of extensions you have, and the output of journalctl /usr/bin/gnome-shell -o cat | cat ?

myryk31415 commented 9 months ago

I deactivated all other extensions, the issue still persists.

For the command my terminal doesn't show the whole output, is there a way to save the output e.g. in a file?

Rayzeq commented 9 months ago

You can use journalctl /usr/bin/gnome-shell -o cat > shell.log to redirect the logs to a file named shell.log

myryk31415 commented 9 months ago

Okay that worked perfectly but the file is too big for github so here's a link: here was the link Shell.log is without the extension, Shell_after.log is with only this extension after I multiplied the sliders.

Rayzeq commented 9 months ago

First of all, there seems to be a lot of errors from other extensions (I saw dash-to-panel and advanced-alt-tab) that flood the logs. I also noticed that there were errors from QSAP in shell.log, I guess you got the logs after disabling the extension, but that you didn't restart your session, so the old logs are still here. Could you disable every extensions except QSAP, restart your session (by logging out and in again), trigger the issue, and then get the logs ? This would help me debug, because some errors don't have the name of the extension associated with them, and I currently don't understand the cause of the errors I saw from QSAP.

myryk31415 commented 9 months ago

Okay I disabled all the other extensions, logged out and back in. Here's the log: here was the link

Rayzeq commented 9 months ago

Well, there is no errors in the latest logs you gave me, so I really don't have any idea of the cause of the issue. Given that the previous errors are still obscure to me (and I'm pretty certain they're not the cause of this issue, they probably come from a conflict between QSAP and another extension), and that there is apparently no new errors, I can't fix this, but I'll leave this thread open if anybody else have this problem and think they have data to add to help me understand.

myryk31415 commented 9 months ago

okay thanks for trying tho :D. weird thing is it only happens with the device slider, not the app sliders etc.

Rayzeq commented 9 months ago

I've just fixed an issue where the object containing all the device sliders (SinkMixer) wasn't being removed from the panel. This correction means that sliders should always disappear when you disable them or the extension. However, even before the fix, instances of SinkMixer that were not removed from the panel should have been empty (and thus not visible). This means that this is another error that prevents the slider from disappearing, but it may be related to the fact that several SinkMixers were coexisting, so it may or may not be fixed.

myryk31415 commented 9 months ago

Finally got to trying it again, the device sliders work as expected now! ty man :)

myryk31415 commented 9 months ago

is fixed :+1: