Open preethamrn opened 11 months ago
I'm planning on fixing the failing tests but would like to hear opinions on how to best implement and integrate this feature before making too many more changes.
Hello! This would be a useful feature indeed.
Clamping probably shouldn't be implemented in RecordFilterInteractor because it's purpose is to filter records and not change them. For example this interactor is used to get records that are going to be changed in Data Edit screen, and it would break the logic if the records are not original.
I think it would make more sense to create another interactor what would perform clamping and use it on filtered records there it is necessary.
I think there should be a feature to clamp time records to the filtered time range instead of including the full record length. This way, it's possible to get statistics for that specific time range (eg. Activity Durations) instead of displaying the full activity.
Scenarios in which this is useful: Let's say I have a Work record that typically goes from 900-1700. On one day, the record goes from 900-1900. If I filter the time range from 1700-2200 then I will see this 10 hour Work record even though I'm more interested in the time range after work and would expect to only see 2 hours of Work.
There are a handful of changes in this pull request: