search

Razeeman / Android-SimpleTimeTracker

Simple app that tracks time.
GNU General Public License v3.0
631 stars 80 forks source link

fix: Force second display when less than 1 minute #207

Open cogk opened 2 months ago

cogk commented 2 months ago

After

a

Before

b

Razeeman commented 2 months ago

Thank you for suggestion. Have mixed feelings about this one. Original implementation was like presented in this PR - show seconds on records shorter than 1 minute even if "show seconds" is off. Later it was changed to current implementation. Main reason was for consistency, if "show seconds" is off it could be somewhat strange to show seconds anyway. But on the other side it could be better to show some meaningful information (seconds) instead if "0 minutes". So both implementations have some reasoning behind. Another point is that I can't remember if anyone asked for it to be one way or another, so probably it doesn't matter, because probably no one is tracking such short records with "show seconds" disabled and need to see seconds at the same time. So I'd rather leave it as it is unless you have some counterpoints.

cogk commented 1 month ago

probably no one is tracking such short records with "show seconds" disabled and need to see seconds at the same time

Well… I do 😂

I feel like “Show seconds” is overwhelming, but I still kinda want to see seconds on short records (< 1 min) for aesthetic reasons AND also disable the rounding introduced recently. To be fair, my use-case* is probably not relevant haha

*My shortest record is 7 seconds, longest is 19 hours. Around 2% of my records are below one minute, so this is definitely not critical for me.

Anyways feel free to close this PR, I won't mind 😃