RazerMS / Mobile-XDK-RazerMS_React_Native

Razer Merchant Services mobile payment for React Native
https://merchant.razer.com/v3/
10 stars 13 forks source link

Could not find com.android.volley:volley:1.0.0 on RN 0.65 #40

Closed chungweileong94 closed 5 months ago

chungweileong94 commented 3 years ago
> Could not find com.android.volley:volley:1.0.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/com/android/volley/volley/1.0.0/volley-1.0.0.pom
       - file:/Users/chungwei/.m2/repository/com/android/volley/volley/1.0.0/volley-1.0.0.pom
       - file:/Volumes/MacExtDrive/Projects/drop/node_modules/react-native/android/com/android/volley/volley/1.0.0/volley-1.0.0.pom
       - file:/Volumes/MacExtDrive/Projects/drop/node_modules/jsc-android/dist/com/android/volley/volley/1.0.0/volley-1.0.0.pom
       - https://dl.google.com/dl/android/maven2/com/android/volley/volley/1.0.0/volley-1.0.0.pom
       - https://www.jitpack.io/com/android/volley/volley/1.0.0/volley-1.0.0.pom
     Required by:
         project :app > project :molpay-mobile-xdk-reactnative-beta
azmanjamlie commented 2 years ago

Hi, How about this issue? any workaround?

chungweileong94 commented 2 years ago

@azmanjamlie It doesn't work because jcenter is removed starting from RN 0.65, due to the jcenter is now ready-only.

But this won't stop you from adding it back to your project.

allprojects {
    repositories {
        ...

        // TODO: Remove jcenter()
        // Started from RN 0.65, jcenter not longer include by default,
        // However, there are some packages still rely on it
        // - molpay-mobile-xdk-reactnative-beta
        jcenter()
    }
}
chungweileong94 commented 2 years ago

@wankimmy I don't get why this issue is closed, does it fixed? Because I don't see any new release to address this.

wankimmy commented 2 years ago

@wankimmy I don't get why this issue is closed, does it fixed? Because I don't see any new release to address this.

Hi @chungweileong94 , you may refer from this latest release https://www.npmjs.com/package/molpay-mobile-xdk-reactnative-beta

chungweileong94 commented 2 years ago

@wankimmy I don't get why this issue is closed, does it fixed? Because I don't see any new release to address this.

Hi @chungweileong94 , you may refer from this latest release https://www.npmjs.com/package/molpay-mobile-xdk-reactnative-beta

Yeah, as far as I can tell, I don't think the latest release fixed the issue by looking at the source https://socket.dev/npm/package/molpay-mobile-xdk-reactnative-beta/files/0.32.0/android/build.gradle

wankimmy commented 2 years ago

@hisyamadzha may need your help to look into this

hisyamadzha commented 2 years ago

@chungweileong94 You may replace jcenter() to mavenCentral()

chungweileong94 commented 2 years ago

@hisyamadzha

@chungweileong94 You may replace jcenter() to mavenCentral()

Nope, pretty sure it doesn't fix the problem, I did make sure I have the mavenCentral(), image

tw0517tw commented 2 years ago

@wankimmy @hisyamadzha I think maybe you can update the volley version from 1.0.0 to a newer version which is hosted in new repos to fix this

tw0517tw commented 2 years ago

And this become important because JCenter is down today and nobody knows when it will come back. https://stackoverflow.com/questions/74258160/is-jcenter-down

chungweileong94 commented 2 years ago

@wankimmy @hisyamadzha Is there any chance that the XDK library can be open source? As we have encountered several issues with the package for the past few years, especially when there's a major OS update where things could break unexpectedly, and we have no choice have to either patch it or wait for the update (which could take months 🫤).

wankimmy commented 2 years ago

@wankimmy @hisyamadzha Is there any chance that the XDK library can be open source? As we have encountered several issues with the package for the past few years, especially when there's a major OS update where things could break unexpectedly, and we have no choice have to either patch it or wait for the update (which could take months 🫤).

hi @chungweileong94 and @tw0517tw , you may run npm-update, we already fixed the issue, you may refer the update here

https://www.npmjs.com/package/molpay-mobile-xdk-reactnative-beta

tw0517tw commented 2 years ago

Thanks for your quick response @wankimmy !