Enable github actions - Githubissues

Razican / vsop87-rs

VSOP87 algorithm in Rust

https://crates.io/crates/vsop87

Apache License 2.0

16 stars 8 forks source link

Enable github actions #25

Closed rillian closed 11 months ago

rillian commented 3 years ago

Some further cleanup I did on the master branch after submitting #24, in case you'd like to do something similar.

Remove custom lints, since they don't seem portable.
- Fixes cargo +nightly bench
Starter github actions script, since travis is dropping their free tier.
- Default branch only; might need amending since you use dev branches.
Opt into rust 2018 edition for better future-proofing.
Bump rand to reduce the dep count.

Please let me know if you'd like me to redo this against another branch.

Razican commented 3 years ago

Thanks for the PR, most of these changes will be available as soon as I release the 2.1.0 version, which I expect to do before the end of the year, as soon as all tests are passing :)

The only thing I would like to set up would be GitHub actions and using master as the default branch, which I think I will leave it for Q1 next year, since I don't have a lot of free time to do it now, and having an up-to-date version release should be a priority compared to having the CI "right".

rillian commented 3 years ago

No worries. I was just curious about the implementation and found I couldn't build it. :)

I wouldn't say working CI is lower priority than a release though. Continuous integration feedback is a semi-external review of the software's status. It gives both authors and users confidence that the code is in a good state during development and when releases are made.

Thanks for publishing the crate!

Razican commented 3 years ago

No worries. I was just curious about the implementation and found I couldn't build it. :)

I wouldn't say working CI is lower priority than a release though. Continuous integration feedback is a semi-external review of the software's status. It gives both authors and users confidence that the code is in a good state during development and when releases are made.

Yes, but for now, the CI is working, as you can see here. It needs an improvement, though, since it's using a setup that was nice 4 years ago, but now things have changed :)

Thanks for publishing the crate!

I'm happy is helpful!

rillian commented 3 years ago

Ok, I've updated the PR to just add the basic github actions config, since you've addressed the other issues in your own way. Although I still think the custom lint levels will prove to be brittle.

Thanks for unbreaking the default branch! Is there an analysis available of the test failures on Windows?

Razican commented 3 years ago

Ok, I've updated the PR to just add the basic github actions config, since you've addressed the other issues in your own way. Although I still think the custom lint levels will prove to be brittle.

Thanks :) I will give it a look when I have a bit of free time.

Thanks for unbreaking the default branch! Is there an analysis available of the test failures on Windows?

Test failures in Windows seem due to a small stack present in Travis-CI builds, but I'm not sure. I will check it again with GitHub actions.

rillian commented 11 months ago

Looks like this was obsoleted by #29.

Razican commented 11 months ago

Looks like this was obsoleted by #29.

Oh! I thought this was forgotten. I'll review my PR and add your changes if still relevant.