search

Razish / japp

JA++ server and client modification for Jedi Academy
GNU General Public License v2.0
44 stars 30 forks source link

Fix: Spectating allows you to control other clients/bots #310

Open Razish opened 9 years ago

Razish commented 9 years ago

Though it seems things like saber collision and your own hitbox are in totally different areas.

https://www.youtube.com/watch?v=Q2uAztx9Q7k

Related to userinfo flooding via changing skins.

Exmirai commented 9 years ago

how to reproduce it?

Razish commented 9 years ago

Not sure. Apparently just changing skin a load of times (to trigger userinfo spam protection) and then joining the game

ensiform commented 9 years ago

Your userinfo protection or the engine built in one ?

I assume it only affects ja++ for some reason ?

Razish commented 9 years ago

JA++ userinfo protection. Likely triggers a bug in unrelated code.

Blackwolf1337 commented 8 years ago

I would suggest to add a delay, not being able to join a team after spamming userinfo.

Razish commented 8 years ago

I believe the behaviour is (or should be) to just not update their userinfo if they trigger the flood protection, but it sounds like code is assuming that the userinfo change went ahead*. This error should be detected by all parts of the code that attempt to set userinfo and fail early.

* this is troublesome for things like changing between single/dual sabers, switching team, etc

Blackwolf1337 commented 8 years ago

I actually tested this Bug out yesterday and it happens as you described. But it's really weird it let's you spawn where you are with spectator atm and the control worked too but it's only a Phantom other players don't experience it. The biggest problem with this is taht you can merge into another players collission box and trap them.

Von Outlook auf Android gesendet.

Razish commented 8 years ago

Can we get a 100% reproducible example to investigate?

Razish commented 7 years ago

Still no reproducible example. Haven't heard anything regarding this. May be related to ent->s.number being borrowed for spectators. Linking/unlinking? See this related issue.

Blackwolf1337 commented 7 years ago

I am not playing and coding for JKA but yes it was probably something with the entity number

From: Raz0r notifications@github.com Sent: Tuesday, May 23, 2017 3:25:51 PM To: Razish/japp Cc: Blackwolf1337; Comment Subject: Re: [Razish/japp] Fix: Spectating allows you to control other clients/bots (#310)

Still no reproducible example. Haven't heard anything regarding this. May be related to ent->s.number being borrowed for spectators. Linking/unlinking?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Razish/japp/issues/310#issuecomment-303396775, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQ-ZWFSSjKtrk1gG24h_uWEJE2HVCb7Uks5r8t5fgaJpZM4D_EID.