search

Razish / japp

JA++ server and client modification for Jedi Academy
GNU General Public License v2.0
44 stars 30 forks source link

Fix: Player disconnect messages don't display (duplicate) client number #332

Open Razish opened 9 years ago

Razish commented 9 years ago

for duplicate names (i.e. multiple Padawan players) it should show the name we substitute it with

ensiform commented 9 years ago

If the message is coming from the server engine, it will not show because its not updated in the engine I think.

dpadgett commented 9 years ago

the name substitution doesn't work anyway. the numbers all get cleared on map change and then everyone has the same name again.

On Wed, Sep 30, 2015 at 12:57 PM Ensiform notifications@github.com wrote:

If the message is coming from the server engine, it will not show because its not updated in the engine I think.

— Reply to this email directly or view it on GitHub https://github.com/Razish/japp/issues/332#issuecomment-144521894.

ensiform commented 9 years ago

Right. But the number gets added in ClientUserinfoChanged but never sent back to the engine which is why the disconnect message only says the original name.

ensiform commented 9 years ago

I think mods should be able to control the message to be honest.

Maybe a flag in new api that says if mod handles it or not.