Razish / japp

JA++ server and client modification for Jedi Academy
GNU General Public License v2.0
44 stars 30 forks source link

Bad animation bug #356

Closed ghost closed 8 years ago

ghost commented 8 years ago

My people in EFF reported that after i updated Ja++ on our servers sometimes players got disconnected with an animation error:

Bad animation number: 1963

On time when I tried to connect to the server I also got this error and couldn't enter. I found this error in the code here:

https://github.com/Razish/japp/blob/38738284a54cdfd4df97314dfda4879138004430/cgame/cg_players.cpp#L2072

So I would say it's something with emotes? I have no idea what animation can have that number.

ensiform commented 8 years ago

Likely they need to update client side too?

ghost commented 8 years ago

I have an updated client and I got this error one time when I tried to go to server. Once I restarted it the error gone away. We tried to find out what causes it but no luck it seems to happen randomly.

Exmirai commented 8 years ago

give us stack trace please if you can

ghost commented 8 years ago

We figured out what is causing the trouble. It's the spinkick when used with staff saber. As default spinkick is meant to use with melee but staff also has kick on secondary attack button so its possible to make a spinkick with staff. Although when you try to make it you get disconnected and also all those players who have seen you meanwhile. I think the error is happening because of the spinkick it's too much animation in one frame with the regular staff kick.

Exmirai commented 8 years ago

spin kick is.....?

ghost commented 8 years ago

Roundhouse kick, when you are in melee and you kick with your leg while turning around.

McJazzy commented 8 years ago

Can confirm / reproduce. Happens when you roundhousekick yourself, or when someone else does it with a staff. Not in all cases though.

JokerMaster commented 8 years ago

i have kind the same Problem wen im using The Red Stance (Single Saber) and Perform that Kick the Particles just stay and cause the game to crash after 1 or sometimes 2 times doing that move shot2015-12-12_11-18-32 shot2015-12-12_11-18-46

Exmirai commented 8 years ago

@JokerMaster its my fault probably...related to localents code >,>

Razish commented 8 years ago

@JokerMaster can you confirm if this happens on latest revision on Windows? I have not been able to reproduce it on Linux for a week or two. If it does, feel free to create a new issue.

Did some basic investigation of this issue, couldn't see where it was getting that absurd animation number. Seems like a translation error between LS_ and BOTH_ enums. A workaround of course is japp_allowSpinkicks 0

JokerMaster commented 8 years ago

Yes this happens on Windows with the latest version and i all ready reinstall but still same problem no difference between OpenJk or not.

Razish commented 8 years ago

I meant specifically the latest git revision, not the latest version available on the JA++ site. It would require compiling it yourself. Could you give me the output of clientinfo when connected to a server and the bug occurs for your own saber trail?

JokerMaster commented 8 years ago

well im not an expert but i hope i got it right. The Saber Trail bug can be forced by anyone on the server wen he does this move. i dont need to see him for that. (without openjk the frame rate goes down to 20 or Crash the game) shot2015-12-13_15-14-32