search

Razish / japp

JA++ server and client modification for Jedi Academy
GNU General Public License v2.0
44 stars 30 forks source link

Fix: JA+ server modelscale prediction errors #387

Open Razish opened 8 years ago

Razish commented 8 years ago

on JA+ servers with modelscale set (e.g. jan on KR server), there are prediction errors when standing on their head

Razish commented 8 years ago

Ping @Blackwolf1337 did you want to look at this before me :)?

Exmirai commented 8 years ago

bboxes are not updated?

ensiform commented 8 years ago

I don't think they are in JA+ either.

Blackwolf1337 commented 8 years ago

@Razish I'll take a look at it.

Blackwolf1337 commented 8 years ago

Ok, I looked over the code and it seems like there is a prediction... the fault is coming from the Ja+ mod itself, since it's not scaling the Boundary Box as @EpicLoyd asked and said. So it is irrelevant to fix it, since it has to do something Serverside. Since the Size Prediction is built in, it bugs for us because the game thinks, that the model is scaled with the boundary box, which isn't. I think this can be closed @Razish ?

Razish commented 8 years ago

If we are getting prediction errors, the bounding boxes are out of sync with the server. Either we are updating them with the modelscale and JA+ server is not, or we are not updating them with the modelscale and JA+ is. Right?

Exmirai commented 8 years ago

afaik ja+ not updating it because if resulting bbox ( after scaling ) will be too high or too wide that can block whole map or significant part.

Blackwolf1337 commented 8 years ago

@Razish, that's totally right. But your ja++ Plugin already has a prediction for it, when scaling models up and down you're getting the prediction. It's just Ja+.