search

Razish / japp

JA++ server and client modification for Jedi Academy
GNU General Public License v2.0
44 stars 30 forks source link

Removed saberBlock* #391

Closed Wookiee- closed 8 years ago

Wookiee- commented 8 years ago

japp_saberBlockChanceMin, japp_saberBlockChanceMax , japp_saberBlockChanceScale, japp_saberBlockStanceParity calls removed.

Used OpenJK method for g_combat.cpp, w_saber.cpp (SabercanBlock, SaberBlock).

Still kept the reduced saberblocks with a small fix from loda from japro.

I have tested this on my Dallas JA++ dev server with another coder friend to evaluate these changes

Blackwolf1337 commented 8 years ago

I already talked about this with @Razish and you shouldn't touch that part of code. Also what OpenJK Fixes??? Can you please link them.

Razish commented 8 years ago

This removes the slept or ghosted playing ignoring saber collisions. There are no "OJK fixes". After comparing the JA++ file before and after this commit, the only effective change is within the japp_saberTweaks.integer & SABERTWEAK_REDUCEBLOCKS segment and the ghosted/slept player changes. The rest is just style changes (i.e. you've reverted my cleaning up of the code, nothing else)

It would be better to still allow these options, but the server owner should balance them more toward what this commit achieves. This post describes the effects.

If this still isn't suitable, and you really do want a clear-cut, consistent method for reducing blocks like japro's method (if their stance > my stance don't block) then we can add that as another option. I don't support removing these options.

I already talked about this with @Razish and you shouldn't touch that part of code.

I'm open to ideas and definitely feedback, but I'm hesitant to just go ahead and change things without testing and/or being involved in the process.

Wookiee- commented 8 years ago

@Razish Sorry I had no idea there was a thread on the JAWA forums concerning this.

@Blackwolf1337 I was a little offended by your comment about not touching that code, I know what it does and I was trying to revert it back. After reading the post on the JAWA forums and explained how it works I now understand why it is in there.

Blackwolf1337 commented 8 years ago

@Wookiee- Sorry about that I think, I misspelled myself. Well didn't knew that you posted on JKHub forums also. -EDIT- Since I am not anymore active on JKHub forums, it would be cool if you guys could also link those ideas here.

Wookiee- commented 8 years ago

No worries