Razish / japp

JA++ server and client modification for Jedi Academy
GNU General Public License v2.0
44 stars 30 forks source link

Fix: g_forceClientUpdateRate causes hitches #394

Open Wookiee- opened 8 years ago

Wookiee- commented 8 years ago

Razor and I have been testing the current build of ja++ and it seems the mod is causing cpu hitches causing problem of the thirdperson camera going out of whack for a 1 second.

Wookiee- commented 8 years ago

Found the problem I think it maybe openjk with Net_Sleep etc https://github.com/JACoders/OpenJK/commit/7b1256ba0a46789986383567f76fa9717b39cfb4. I could be wrong but just throwing out idea's.

Seems more of an issue with camera angles.

ensiform commented 8 years ago

That's not likely to be reverted even if it has a cause to this at all.

Wookiee- commented 8 years ago

Ok, I found an old openjkded.x86_64 and still doing the same issue so Net_Sleep is ruled out.

Wookiee- commented 8 years ago

I think I have found the problem g_forceClientUpdateRate 250 - Force a client update if a movement command is not received within x milliseconds.

I have set it to 0 and it seems to have solved the issue, though I maybe wrong.

ensiform commented 8 years ago

Shouldn't be causing a hitch. Are you getting a hitch on the server or client. This ensures you don't cheat through triggers etc with low snaps and other lag related problems or cheat lag.

Wookiee- commented 8 years ago

This is serverside after showing Razor on my aussie ja++ server, I will let razor comment on this.

ensiform commented 8 years ago

If that's the case though it (potentially) affects OJK's server mod code too.

Razish commented 8 years ago

The issue is definitely server-side hitches. g_forceClientUpdateRate does have a noticeable effect, but I'm not entirely sure if that's the root cause or just exposing the real issue more frequently (i.e. a hitch in Clientthink_real)