Razor-qt / razor-qt

Razor is now LXQt:
http://lxqt.org
Other
366 stars 78 forks source link

Quicklauncher has no feedback #625

Closed AndyM48 closed 10 years ago

AndyM48 commented 11 years ago

Quicklaunch does not have any feedback at all, no indication that the launch button has been pressed. Some sort of feedback would be nice.

kuzmas commented 11 years ago

It depends on theme, I presume. Try new 'flat' theme to test the issue.

AndyM48 commented 11 years ago

Yes, the flat theme has nice button-press feedback.

But the icons in the panel do not scale correctly :(

Andrew

On 06/06/13 00:08, Kuzma Shapran wrote:

It depends on theme, I presume. Try new 'flat' theme to test the issue.

— Reply to this email directly or view it on GitHub https://github.com/Razor-qt/razor-qt/issues/625#issuecomment-19012386.

kuzmas commented 11 years ago

Well, scaling is not directly related to themes and is just another problem. :-(

AndyM48 commented 11 years ago

It may well be connected to the feedback issue if you have used different widget settings.

Light Theme snapshot1

Flat Theme snapshot2

Can you tell me what you changed to get the feedback?

Cheers

Andrew

On 06/06/13 09:58, Kuzma Shapran wrote:

Well, scaling is not directly related to themes and is just another problem. :-(

— Reply to this email directly or view it on GitHub https://github.com/Razor-qt/razor-qt/issues/625#issuecomment-19030153.

kuzmas commented 11 years ago

From light/razor_panel.qss:

Plugin > QToolButton, 
Plugin > QWidget > QToolButton {
    margin: 0;
    border: 2px solid transparent;
    border-radius: 3px;
    color: black;
    qproperty-iconSize: 22px;
}

Plugin > QToolButton:pressed {
    margin: 2px 0 0 2px;
    border: none;
}
...

#DesktopSwitch QToolButton {
    margin: 1px;
    color: #555555;
    border: 1px solid #B0B0B0;
    background: rgba(0, 0, 0, 5%);
}

RazorPanel[position="0"] #DesktopSwitch QToolButton,
RazorPanel[position="1"] #DesktopSwitch QToolButton
{
    margin-bottom: 4px;
    margin-top: 4px;
}

#DesktopSwitch QToolButton:on {
    background: rgba(255, 255, 255, 40%);
    border: 1px solid #80a8d3;
}

#DesktopSwitch QToolButton:hover {
    border: 1px solid #80a8d3;
}
...

#TaskBar > QToolButton:on {
    background: rgba(255, 255, 255, 80%);
}

#TaskBar > QToolButton:on,
#TaskBar > QToolButton:hover {
    margin: 4px 1px 4px 1px;
    border-radius: 4px;
    border: 1px solid #80a8d3;
}

from flat/razor_panel.qss:

QToolButton,
TrayIcon,
#RazorMountPopup > MenuDiskItem {
    margin: 1px;
    border: 1px solid transparent;
    padding: 0px;
    font-size: 9pt;
    color: hsv(0, 0, 64);
    qproperty-iconSize: 24px;
}

QToolButton:hover,
TrayIcon:hover,
#RazorMountPopup > MenuDiskItem:hover {
    border: 1px solid hsv(0, 0, 224);
}

QToolButton:on,
TrayIcon:on {
    background: hsv(0, 0, 176);
}

QToolButton:pressed,
TrayIcon:pressed {
    background: hsv(0, 0, 160);
}

so the difference is in :hover, :on & :pressed states.

kuzmas commented 11 years ago

Try to make the panel height a little bit bigger. Looks like the nearest smallest size for icons is really tiny.

AndyM48 commented 11 years ago

Interestingly in the Light theme the icons scale very well, but in the Flat theme they just shrink to the small size shown in my screenshot. The difference occurs when implementing the "hover" "border" as far as I can see, without the border, no feedback, but perfect scaling. With the border, even set to 0px, there is feedback, but incorrect scaling.

I am really sorry, but I do not understand Qt widgets and qss. I would be interested if you could point me to a manual or something like that.

Andrew

On 06/06/13 22:33, Kuzma Shapran wrote:

Try to make the panel height a little bit bigger. Looks like the nearest smallest size for icons is really tiny.

— Reply to this email directly or view it on GitHub https://github.com/Razor-qt/razor-qt/issues/625#issuecomment-19072169.

kuzmas commented 11 years ago

There is a work in progress on a document about themes on our wiki: https://github.com/Razor-qt/razor-qt/wiki/Theming, but it already may have some useful information for you.

AndyM48 commented 11 years ago

Thank you very much

Andrew

On 08/06/13 23:08, Kuzma Shapran wrote:

There is a work in progress on a document about themes on our wiki: https://github.com/Razor-qt/razor-qt/wiki/Theming, but it already may have some useful information for you.

— Reply to this email directly or view it on GitHub https://github.com/Razor-qt/razor-qt/issues/625#issuecomment-19155502.

AndyM48 commented 11 years ago

OK, I always listen to advice given.

So I have built a theme which reflects most of my ideas, except for the following:

I do not know how to change the settings for the Sensors plugin

Autosuspend - again, I do not know how to refer to the notification settings (e.g. Discharging - 30%)

Desktop Menu - (right click on the desktop) does not seem to follow the MainMenu qss settings.

Items from Razor-qt Settings appear in the task manager with a standard icon instead of the one assigned in the .desktop file

Apart from those I think it is pretty much finished.

Happy to share if anyone would like to see it.

Andrew

kuzmas commented 11 years ago

On 13 June 2013 20:58, Andrew notifications@github.com wrote:

OK, I always listen to advice given.

So I have built a theme which reflects most of my ideas, except for the following:

I do not know how to change the settings for the Sensors plugin

Most probably - not every aspect of UI exposed to QSS.

Autosuspend - again, I do not know how to refer to the notification settings (e.g. Discharging - 30%)

I don't have a battery, can't help you here, sorry.

Desktop Menu - (right click on the desktop) does not seem to follow the MainMenu qss settings.

Use QMenu class or #TopLevelMainMenu object name - it works, I've checked.

Items from Razor-qt Settings appear in the task manager with a standard icon instead of the one assigned in the .desktop file

It's not a part of a theme and also an icon in the taskbar - is the same icon from the corner of a window. This window icon is set up by application itself when it's started, not described in a desktop file. As you might know - applications in Linux do not have embedded icons like in Windows, that's why they look the same in a file browser. Desktop file has an icon instead. One application can have several desktop files with different icons (It's unusual but possible). But window icon depends solely on an app itself.

Apart from those I think it is pretty much finished.

Happy to share if anyone would like to see it.

Andrew

— Reply to this email directly or view it on GitHubhttps://github.com/Razor-qt/razor-qt/issues/625#issuecomment-19379837 .

Cheers, Kuzma

AndyM48 commented 11 years ago

The icon used in windows (corner) and other places is usually defined by the icon theme, in my case Oxygen. But for razor it seems to be hard coded into the programmes. Very strange.

Thanks for the other information. I will do a final update to the theme as soon as possible.

Andrew

jleclanche commented 10 years ago

If this is still an issue in LXQt, please reopen there.