search

RazrFalcon / resvg

An SVG rendering library.
Mozilla Public License 2.0
2.61k stars 215 forks source link

Add support for decoding WebP images #747

Open notjosh opened 2 months ago

notjosh commented 2 months ago

Hiya 👋

I was hoping to use WebP in a project, and noticed (via #575) that the image-webp project has been published now. This PR adds support for the project within resvg.

As noted in #575 there may be performance issues - I haven't tested extensively. However in my use case, it saves a step of converting .webp images to a compatible format, so even a slow(ish) implementation is an overall positive. With that in mind, it feels like a step forward for resvg to support WebP, even if there's still room in future for their (pre-1.0) project to improve.

RazrFalcon commented 2 months ago

Looks good to me. All we have to do now is to ask them nicely to stop using thiserror.

RazrFalcon commented 2 months ago

https://github.com/image-rs/image-webp/issues/66

RazrFalcon commented 2 months ago

Looks like we need a MSRV bump as well.

RazrFalcon commented 2 months ago

Ok, waiting for 0.1.3 and I'm ready to merge.