search

RazrFalcon / rustybuzz

A complete harfbuzz's shaping algorithm port to Rust
MIT License
498 stars 34 forks source link

Add a codegen check to the CI #78

Closed notgull closed 10 months ago

notgull commented 10 months ago

This ensures that all generated code is up to date.

RazrFalcon commented 10 months ago

Sorry, but I don't think this is a good idea. I don't want to have a complicated CI. Especially building C from sources. A minor GCC/autotools update and good luck figuring out what is wrong. Nah.

Also, you cannot really forget to update those files, because tests would be failing.

notgull commented 10 months ago

Okay, I'll reopen it once there is progress on https://github.com/taiki-e/install-action/issues/199

RazrFalcon commented 10 months ago

No, I don't think we need any changes to CI at all. It's fine.

notgull commented 10 months ago

Are you sure? I help maintain x11rb, which uses a lot of pre-generated code. Having a check like this is invaluable for preventing the usual mistake of "forgot to run the build scripts again".

RazrFalcon commented 10 months ago

forgot to run the build scripts again

It would not happen, because tests would fail. We have almost 2000 tests. The chance you forget something is tiny. Again, simplicity is king. The current CI is good enough.