search

RazrFalcon / svgcleaner

svgcleaner could help you to clean up your SVG files from the unnecessary data.
GNU General Public License v2.0
1.62k stars 93 forks source link

Add back Cargo.lock to source tarball #157

Open vincentbernat opened 6 years ago

vincentbernat commented 6 years ago

Hey!

From 0.9.3, Cargo.lock is not shipped anymore. It is useful for some packaging systems, like Nix, which rely on this file to ensure a reproducible build. If it was removed by mistake, it would be nice to add it back.

bachp commented 6 years ago

I second this.

As svgcleaner is a binary it should include a Cargo.lock file. This is also recommended by the Cargo Book FAQ

RazrFalcon commented 6 years ago

Will add it back. I've removed it because I thought that it's useless.

RazrFalcon commented 6 years ago

Should I add to the master or should I create a new tag/release?

vincentbernat commented 6 years ago

As for updating in Nix, we can work without a release (we can add back the Cargo.lock through a patch). So, master would be enough.

ghost commented 5 years ago

@RazrFalcon I would be glad for creating a new release - I would then update the package in the nixpkgs repository.

samford commented 4 years ago

In the process of making changes to formulae in the Homebrew package manager, I noticed that svgcleaner was one of a handful of Rust binary projects without a Cargo.lock file in version control, so I thought I might try to revive this issue in hopes of moving this forward.

I'm looking to add the --locked flag to Homebrew formulae that build from source using cargo install, so having a Cargo.lock file for svgcleaner would be helpful. As mentioned in previous comments, this is recommended in the Cargo book for binary projects anyway.

Since you also publish this as a library, if you add the Cargo.lock file back to version control, you'll seemingly need to modify the exclude array in Cargo.toml's [package] section to also exclude Cargo.lock from the package (since libraries shouldn't include a Cargo.lock file).

RazrFalcon commented 4 years ago

@samford The project is sort of dead. To bump a version I have to build cli/gui packages too. Which will take a lot of time and I don't have any right now.

I should add vendored packages too.

samford commented 4 years ago

I appreciate the response. I don't speak for everyone here but I would be fine with just having the Cargo.lock file in master without a new release, if you have the time for that. If not, that's entirely understandable.

RazrFalcon commented 4 years ago

@samford I've pushed the Cargo.lock and maybe will bump a version later this month.

samford commented 4 years ago

Thanks!