search

RazrFalcon / tiny-skia

A tiny Skia subset ported to Rust
BSD 3-Clause "New" or "Revised" License
1.05k stars 67 forks source link

PSA: Do not replace arrayvec with tinyvec #65

Closed notgull closed 1 year ago

notgull commented 1 year ago

I'll open and close this issue, if nothing else than to use as precedent if anyone else wants to do this.

I tried replacing the usage of arrayvec in this crate with tinyvec, with is an alternative with no unsafe code. However, this caused a significant degradation of performance in the benchmarks for this crate. Therefore, I don't think it is a good idea to replace arrayvec with tinyvec.

RazrFalcon commented 1 year ago

Thanks. I think I've tried this as well with poor results.

As for unsafe, we don't have much, except SIMD, which might be improved with #59