stroker: Don't switch line_join from MiterClip to Bevel with miter_limit <= 1.0

RazrFalcon / tiny-skia

A tiny Skia subset ported to Rust

BSD 3-Clause "New" or "Revised" License

1.05k stars 67 forks source link

stroker: Don't switch line_join from MiterClip to Bevel with miter_limit <= 1.0 #93

Closed torokati44 closed 1 year ago

torokati44 commented 1 year ago

Really sorry for the trouble again, I saw you just recently released and published 0.11.0...

As it turns out, one simple change that I did right before submitting #91, actually broke my "nearly perfect" results when comparing to Flash Player - which was the main reason I implemented MiterClip in the first place...

So this PR restores it to the state where the match with FP is actually nearly perfect.

Since this time it should really only accept MiterClip, I hope you will accept it.

RazrFalcon commented 1 year ago

No problem. Stroking is very complicated.

resvg tests are passing with this patch, so I will publish 0.11.1 soon.

torokati44 commented 1 year ago

Amazing, thank you for the super quick merge! :pray:

RazrFalcon commented 1 year ago

Published.