Fix formatting of \0 in tests

RazrFalcon / xmlparser

A low-level, pull-based, zero-allocation XML 1.0 parser.

Apache License 2.0

130 stars 16 forks source link

Fix formatting of \0 in tests #20

Closed krtab closed 2 years ago

krtab commented 2 years ago

Tests were broken.

This follows this PR in rustc: https://github.com/rust-lang/rust/pull/95345

Which breakage was discussed here: https://github.com/rust-lang/rust/issues/95732

Because this landed in 1.61.0, the MSRV has to be updated accordingly.

RazrFalcon commented 2 years ago

Interesting. Sadly your solution is not a fix, since we do support Rust 1.31+ I would suggest using \u{1} instead of \0 in tests. This would not require MSRV bump.

krtab commented 2 years ago

Thanks for the quick review. I've changed the diff accordingly. :)

RazrFalcon commented 2 years ago

Thanks!