search

RazrFalcon / xmlparser

A low-level, pull-based, zero-allocation XML 1.0 parser.
Apache License 2.0
130 stars 16 forks source link

style: apply latest clippy suggestions #27

Closed jdrouet closed 1 month ago

jdrouet commented 1 month ago

This has just been made by doing cargo clippy --fix --tests.

clippy 0.1.84 (e92993dbb4 2024-10-18)

udoprog commented 1 month ago

@RazrFalcon It seems like there's something in the repo settings on Github which seems to be preventing the Github action from running over this change. I don't seem to have access to repo settings to review.

Could I get access to fix it or can transfer the repo to my user?

udoprog commented 1 month ago

I think I found the reason. There seems to be a new Github policy in place which disables workflow if a repo hasn't seen any activity for the last 60 days: image

udoprog commented 1 month ago

Thank you!

jdrouet commented 1 month ago

@udoprog and @RazrFalcon I think it would be worth creating an org for that project. I'd be happy to contribute more considering I have some libs depending on it 😉

RazrFalcon commented 1 month ago

We can just invite you to this project, if needed. No need for a project. Also, you can always send a PR, so at least we could review your changes at first.

udoprog commented 1 month ago

Just to note I've already been given ownership of the package on crates.io so the code can be hosted anywhere as long as I can access the settings for the project. It would be nice to preserve the history (issues and discussions), so a project transfer is just a clean option.

@jdrouet If there's anything you want to add or change I'd suggest opening up an issue so we can discuss it. My only focus right now is maintaining the project and ensuring that any bugs found are fixed and released to allow other people like me to safely continue depending on it. An org might be an idea, but I'm not convinced it's worth the overhead right now unless there are plans for major future developments.

jdrouet commented 1 month ago

Fair enough, you're right