search

Razviar / marvelsnaptracker

Marvel Snap Tracker repo
https://marvelsnap.pro/
154 stars 34 forks source link

x86 linux #21

Open phlawlessDevelopment opened 1 year ago

phlawlessDevelopment commented 1 year ago

This should include the v.1.14 Linux x86 release. This is my first time deploying a release through pull requests, so I may have got something wrong. I'll make any changes required to get this working. Documentation to follow.

nickmccurdy commented 1 year ago

How would this work considering Marvel Snap is only available on Windows, Android, and iOS? Anyway I don't think committing releases is appropriate even if we could support Linux, since version control should be used for sources and releases should be used for binaries.

phlawlessDevelopment commented 1 year ago

As mentioned, previously in the messages , it's already working fine on Linux . Most games just work on Linux through steam these days , whether or not the developer decides to add Linux support ( through a tool called Proton).

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Nick McCurdy @.> Sent: Friday, December 30, 2022 2:12:31 AM To: Razviar/marvelsnaptracker @.> Cc: phlawlessDevelopment @.>; Author @.> Subject: Re: [Razviar/marvelsnaptracker] x86 linux (PR #21)

How would this work considering Marvel Snap is only available on Windows, Android, and iOS? Anyway I don't think committing releases is appropriate even if we could support Linux, since version control should be used for sources and releases should be used for binaries.

— Reply to this email directly, view it on GitHubhttps://github.com/Razviar/marvelsnaptracker/pull/21#issuecomment-1367686070, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYRYICYO56RY3G52IJLSR7DWPZAI7ANCNFSM6AAAAAATKPGCYE. You are receiving this because you authored the thread.Message ID: @.***>

nickmccurdy commented 1 year ago

Ah, I wasn't aware that was available outside of SteamOS, nice. Still, I don't think this repository is the right place for those binaries. It would probably be better to set up an automated build process on GitHub Actions.

phlawlessDevelopment commented 1 year ago

Thanks , I'll look into that, I have been struggling to figure out how to publish releases on a repo I don't own, so this is likely to help with that.

Yeah steamOS is the reason we have Proton from what I understand, it's honestly pretty rare these days that a game comes out and doesn't just work.

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Nick McCurdy @.> Sent: Friday, December 30, 2022 10:54:09 AM To: Razviar/marvelsnaptracker @.> Cc: phlawlessDevelopment @.>; Author @.> Subject: Re: [Razviar/marvelsnaptracker] x86 linux (PR #21)

Ah, I wasn't aware that was available outside of SteamOS, nice. Still, I don't think this repository is the right place for those binaries. It would probably be better to set up an automated build process on GitHub Actions.

— Reply to this email directly, view it on GitHubhttps://github.com/Razviar/marvelsnaptracker/pull/21#issuecomment-1367855119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYRYIC5W4DBDL2LIRPN7RH3WP25NDANCNFSM6AAAAAATKPGCYE. You are receiving this because you authored the thread.Message ID: @.***>

FherStk commented 1 year ago

Hi there,

I implemented a bash script which, using a container, clones this repo, generates an Ubuntu native binary file and installs it into the local system: https://github.com/FherStk/marvelsnaptracker-for-ubuntu

Maybe it can also be implemented as a GitHub action in order to automate the Ubuntu binary, but meanwhile, everyone can use my repo to produce an Ubuntu-compatible binary from the original sources.

Kind regards and thanks a lot for your great work and effort, Fher

Razviar commented 1 year ago

Hello! That is incredible work! I'm not sure we should merge this PR into main Tracker version, but we definetly will post a link to your script to help Linux users get it working. Thanks for your contribution!

FherStk commented 1 year ago

Hi,

I'm agree, this PR should not be merged, but maybe some kind of github action can automate a binary generation for ubuntu using my script or some variation? Just an idea.

Thanks to you for your great job, your tracker brings joy to a lot of players, including me 😊

Thanks again and have a great 2023! Fher

feydreva commented 1 year ago

Hello,

Could you ffer release for linux. Game works great on linux with steam.

I see that someone packaged for ubuntu, I dont use ubuntu, Could we have a app image of it instead of a deb package ??

FherStk commented 1 year ago

Hello,

Could you ffer release for linux. Game works great on linux with steam.

I see that someone packaged for ubuntu, I dont use ubuntu, Could we have a app image of it instead of a deb package ??

Hi @feydreva,

Which Linux distro do you use? Maybe you can fork and modify a little bit my repo (https://github.com/FherStk/marvelsnaptracker-for-ubuntu) in order to adapt it to your distro. Or even you can generate your own native images, following my scripts as a guide.

Let me know if I can help somehow, Fher

feydreva commented 1 year ago

Hey @FherStk I am using Arch. yes I saw your script. But I don't think to be good enough to adapt it :)

FherStk commented 1 year ago

Hey @FherStk I am using Arch. yes I saw your script. But I don't think to be good enough to adapt it :)

Trust yourself and try to adapt it, its the best way to improve your skills and revert some profit into the open-source community.

I'm not an Arch user (nor developer) but maybe some reach us and helps. Fingers crossed.

Kind regards, Fer